Pretty good little article on what makes good dialogue.
"Anyone can write a bunch of talking, but talking isn’t dialogue. Like every other word in your novel, dialogue is there to do a job — a number of jobs, in fact. It needs to move the story forward, to give information, to intensify characterisation. Ideally, it should do all three at once."